Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed test case CG15 #1369

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

MattMiss
Copy link
Contributor

Description

Added CG15 test case in readingsCompareGroupFlow.js

Partly Addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

None

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @MattMiss for their first contribution to OED. Review and testing found it works as expected. I made one small comment on a string to address.

src/server/test/web/readingsCompareGroupFlow.js Outdated Show resolved Hide resolved
@MattMiss MattMiss requested a review from huss October 28, 2024 18:25
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @MattMiss for the updated code. Everything looks good. Congratulations on your first accepted contribution to OED.

@huss huss merged commit fb72497 into OpenEnergyDashboard:development Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants