Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Admin Alert When Meter Is Set as Non-displayable (Resolved Issue#743) #1368

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

danielshid
Copy link
Contributor

Description

I added an admin alert that pops up when a meter is set as non-displayable, which lists the groups the meter is used in and prompts the user to either confirm or cancel.

Fixes #743

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @danielshid for another contribution. Review and testing found it works as specified. I did made one comment about how it functions that was not specified in the issue. I would appreciate you addressing it.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @danielshid for doing the requested update for a changed requirement. Review and testing found it works as desired. For the record, I modified the notice text to something I thought worked a little better (I just decided this). Congratulations on another accepted contribution.

@huss huss merged commit 3c6192c into OpenEnergyDashboard:development Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Giving warnings when setting displayable to false (groups)
2 participants