-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket 1196 #1361
Ticket 1196 #1361
Conversation
…l disappear upon successful login so it is seamless
… the current page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @96gunna and @JoshuaRivera209 for their first contribution to OED. Review and testing found it generally works fine. It is a nice touch that you also added the close button on the login modal. I did make a couple of small comments to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @96gunna and @JoshuaRivera209 for addressing the comments. Review and testing found it works as expected. Congratulations on your first accept contribution to OED.
Description
Ticket completed by @96gunna and @JoshuaRivera209.
Login action now allows the user to login through a modal rather than a separate web page. After authentication, the modal goes away and the user can explore the page they're were already on with admin permissions. The logout action no longer automatically redirects to the home page unless the user was on a page that an unauthenticated user is not allowed to view.
Fixes #1196
Type of change
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations