Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 1196 #1361

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Ticket 1196 #1361

merged 13 commits into from
Oct 22, 2024

Conversation

96gunna
Copy link
Contributor

@96gunna 96gunna commented Oct 17, 2024

Description

Ticket completed by @96gunna and @JoshuaRivera209.
Login action now allows the user to login through a modal rather than a separate web page. After authentication, the modal goes away and the user can explore the page they're were already on with admin permissions. The logout action no longer automatically redirects to the home page unless the user was on a page that an unauthenticated user is not allowed to view.

Fixes #1196

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @96gunna and @JoshuaRivera209 for their first contribution to OED. Review and testing found it generally works fine. It is a nice touch that you also added the close button on the login modal. I did make a couple of small comments to address.

src/client/app/components/HeaderButtonsComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/LoginComponent.tsx Show resolved Hide resolved
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @96gunna and @JoshuaRivera209 for addressing the comments. Review and testing found it works as expected. Congratulations on your first accept contribution to OED.

@huss huss merged commit 32564b7 into OpenEnergyDashboard:development Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modal for new login
3 participants