Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanup/fixes #42

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Misc cleanup/fixes #42

merged 7 commits into from
Sep 6, 2024

Conversation

CursedFlames
Copy link
Member

  • move CloPos into CubicChunksCore
  • fix mixin config auto-generation (by truncating existing files when writing)
  • change CubePos long packing to match CloPos
  • bump NeoGradle and remove p prefix for parameters
  • rename CloPos.asLong to chunkAsLong and cubeAsLong
  • rename dasm sets to GlobalSet, ChunkToCloSet, and ChunkToCubeSet and refactor slightly

NotStirred
NotStirred approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@NotStirred NotStirred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

You pushed to core main, smh.

@NotStirred NotStirred merged commit c35f24f into 1.20.4 Sep 6, 2024
1 check passed
@NotStirred NotStirred deleted the 1.20.4_cleanup branch September 6, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotStirred NotStirred NotStirred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CursedFlames @NotStirred