Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registry/attribute errors in tests mocking the server player #35

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Fix registry/attribute errors in tests mocking the server player #35

merged 6 commits into from
Mar 15, 2024

Conversation

Steveplays28
Copy link
Contributor

@Steveplays28 Steveplays28 commented Mar 14, 2024 •
edited
Loading

  • Mock ServerPlayer#connection
  • Fix region ticket verification
  • Re-enable TestServerPlayer#testTeleportToVanilla

@Steveplays28 Steveplays28 marked this pull request as ready for review March 15, 2024 12:59
@Steveplays28
build: Fix JUnit trying to test Mixin classes
3c919bd 
Also added `abstract` modifiers to all mixin test classes, and did a small local variable rename.
NotStirred
NotStirred reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@NotStirred NotStirred left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments
Thoughts on having a TODO comment on each of the neoforge registry fixes? I think they're only necessary due to us using loom for running tests while neoforge gets junit working

...va/io/github/opencubicchunks/cubicchunks/mixin/test/common/server/MixinServerPlayerTest.java Outdated Show resolved Hide resolved
@Steveplays28
Copy link
Contributor Author

@NotStirred I've added TODO comments to all the mixins:

// TODO: Remove this mixin class when NeoForge supports JUnit for tests
//  This mixin class is only required due to NeoForge not supporting JUnit for testing yet (a workaround is currently used, involving Loom)
...

@NotStirred NotStirred merged commit 21481f9 into OpenCubicChunks:1.20.4 Mar 15, 2024
1 check passed
@Steveplays28 Steveplays28 deleted the 1.20.4-fix-registry-and-attribute-errors branch March 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotStirred NotStirred NotStirred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steveplays28 @NotStirred