Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Participate IE11 errors on EDIT(remove re-direct on IE) #30

Closed
wants to merge 1 commit into from

Conversation

rooney
Copy link

@rooney rooney commented Apr 18, 2016

@MartijnR
Copy link

MartijnR commented Apr 18, 2016

In my understanding editing an existing record is completely broken in IE. Hence the redirect. Not so?

@rooney
Copy link
Author

rooney commented Apr 22, 2016

@MartijnR OK then

I've updated the commit, the redirect has been restored and now only the error message updated for clarity.

Let me know if it's good now or if you have other tought?

@MartijnR
Copy link

MartijnR commented Apr 25, 2016

I'd prefer to keep it as is, for 2 reasons:

  1. I am very reluctant to add new strings (or change existing strings) unless really really necessary/valuable. We have volunteers for about 20 languages now, and it's hard to get people to update translations. I want to stick to changing/adding strings only when really necessary to not discourage them.
  2. IE is on its way out, so this seems too much customization just for those few IE users. Plus the current message is not incorrect.

If you really want this customization in the OC EE port, then I recommend adding the strings to the jade template instead. This will make merging much easier (and I assume that OC, doesn't want to duplicate translation efforts, and accept that this will only be in English).

@kkrumlian
Copy link

Hey @MartijnR,

Can we make a list of what is exactly broken so we can fix it?

Thank you
Krikor

@MartijnR
Copy link

MartijnR commented May 3, 2016

The only non-style issues I'm aware of is that loading (i.e. merging into the default model) any record (draft record, or submitted-record-to-edit) fails with an exception on IE11. That would be the one to fix.

It's only been described here: kobotoolbox#352, and probably occurs in the mergeXML library: https://github.com/hareko/js-merge-xml, which would then be the place to fix it.

I spend some time on it myself, but gave up.

However, there may be very well be other undiscovered issues in IE11.

@MartijnR
Copy link

underlying issue fixed

@MartijnR MartijnR closed this May 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants