Make girder-ui compatible with material-ui v4 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryos
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the package
redux-form-material-uiis not compatible with material-ui v4.redux-form-material-uisimply wraps the various material-ui form elements in a way that can be fed directly to aredux-formfield. This package hasn't been updated in a year, and the version compatible with material-ui >= 1.0 has never made it out of beta. I'm actually surprised it worked as long as it did.Anyway, the fix is easy, we can stop using
redux-form-material-uiand instead implement the glue betweenredux-formandmaterial-uiourselves as documented here: https://redux-form.com/8.2.2/examples/material-ui/Fixes OpenChemistry/stemclient#18