Skip to content

Commit

Permalink
Merge pull request #845 from OpenChemistry/sentry-take-2
Browse files Browse the repository at this point in the history
Remove sentry build args
  • Loading branch information
cjh1 authored Jul 11, 2023
2 parents 99582de + 4ce5b1b commit e286fd4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
FROM node:18.6.0 as build
COPY ./distiller /distiller
ARG REACT_APP_API_URL
ARG REACT_APP_SENTRY_DSN_URL
RUN cd /distiller && yarn && REACT_APP_API_URL=$REACT_APP_API_URL REACT_APP_SENTRY_DSN_URL=$REACT_APP_SENTRY_DSN_URL yarn build
RUN cd /distiller && yarn && REACT_APP_API_URL=$REACT_APP_API_URL yarn build

FROM nginx
COPY --from=build /distiller/build/ /usr/share/nginx/html
Expand Down
2 changes: 1 addition & 1 deletion frontend/scripts/docker_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

TAG=`git log -1 --pretty=%h`

docker build --build-arg REACT_APP_SENTRY_DSN_URL=$REACT_APP_SENTRY_DSN_URL -t openchemistry/distiller-client:$TAG -f ../Dockerfile ../ $@
docker build -t openchemistry/distiller-client:$TAG -f ../Dockerfile ../ $@

0 comments on commit e286fd4

Please sign in to comment.