Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PDB File Import to Support Trajectory Data in Avogadro #1659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinayakjeet
Copy link

@vinayakjeet vinayakjeet commented Mar 30, 2024

Pull Request #1524

This PR updates pdbformat.cpp to improve the handling of PDB trajectories, aligning with community guidelines for file processing without integrating GUI elements. Key enhancements include:

  • Frame Separation with ENDMDL: Implements detection of ENDMDL to identify and separate frames within PDB trajectories, enabling accurate animation and analysis of sequential models.

  • Frame Position Storage: Accumulates atomic positions per frame until ENDMDL, then stores these as distinct frames in the molecule, facilitating correct trajectory visualization.

  • Final Frame Processing: Ensures the last set of positions is added as a frame, improving robustness in handling diverse PDB files.

Closes #1524.

Signed-off-by: Vinayakjeet Singh Karki <[email protected]>
Copy link

welcome bot commented Mar 30, 2024

Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import trajectories from PDB files
1 participant