Remove trailing whitespace and fix some issues in templates #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very nice! Can you adapt the sg.yaml test? |
|
So I had to restore the Singapore template, because it has both country and city boundaries on the same relation. So the city isn't present in Nominatim responses, and formatted addresses are wrong. I have uncoupled the city from the country, but not sure if it stays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly removes trailing whitespace. Also unwrapped single-choice
{{#first}}s.Two important changes hidden in big diffs: Singapore's template was broken, it added country twice. And in Taiwan's,
city_districtwas mentioned twice.