Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for identical boot configs in postgres.Update function #58

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

synackd
Copy link
Collaborator

@synackd synackd commented Dec 25, 2024

fixes #56

Fixes a negated check that should have been a positive check in postgres.Update. This PR also updates the internal postgres.getNodesWithConfigs function to allow blank arguments in order to return all node/config combinations that exist.

Copy link
Member

@alexlovelltroy alexlovelltroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexlovelltroy alexlovelltroy merged commit 87e702f into main Jan 8, 2025
3 checks passed
@alexlovelltroy alexlovelltroy deleted the synackd/fix-disappearing-params branch January 8, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BSS bootparameter entities dissapears
2 participants