Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] SecCompanyFilings: Purge nan Values & Make form_type Match #6846

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • When attempting to filter for Form 4 resulted in other types of forms with '4' in it.
    • Unexpected nan values from empty dates.
  2. What?:

    • Filters the form_type using "isin" instead of "contains".
    • Moves nan replace to the bottom, immediately before the output.
  3. Impact:

    • Improved precision in the results.
    • Bug fix.
  4. Testing Done:

# Multiple forms with '4' in it
obb.equity.fundamental.filings("CRM", form_type='4,144,S-4', limit=0, provider="sec")

# Just Form 4
obb.equity.fundamental.filings("CRM", form_type='4', limit=0, provider="sec").to_df().report_type.unique()

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Oct 22, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit f8a45fa Oct 23, 2024
13 checks passed
@IgorWounds IgorWounds deleted the bugfix/sec-company-filings branch October 23, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants