Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Government Yield Curves + Chart #6417

Merged
merged 43 commits into from
May 21, 2024
Merged

Conversation

deeleeramone
Copy link
Contributor

WIP

  1. Why? :

    • Standardize and consolidate yield curve endpoints.
    • Add EconDB to the mix with country parameter.
    • Add charts.
  2. What? (1-3 sentences or a bullet point list):

    • To replace us_yield_curve and eu_yield_curve.
    • Not a replacement for treasury_rates, but could be expanded to be if desired.
    • Providers: econdb, ecb, federal_reserve, fmp, fred
    • Multiple dates allowed for all.
    • Chart compatible with all providers.
  3. Impact (1-2 sentences or a bullet point list):

    • Deprecation warnings added to eu_yield_curve and us_yield_curve.
  4. Testing Done:

    • Integration and unit tests
    • Chart integration tests
    • chart=True/False with all providers.
  5. Reviewer Notes (optional):

    • Any specific focus areas for review?

    • Example: "Please check algorithm compatibility with existing data models."

  6. Any other information (optional)

@deeleeramone deeleeramone added enhancement Enhancement do not merge Label to prevent pull request merge platform OpenBB Platform v4 PRs for v4 labels May 15, 2024
@deeleeramone deeleeramone removed the do not merge Label to prevent pull request merge label May 16, 2024
@IgorWounds
Copy link
Contributor

@minhhoang1023 @andrewkenreich are you okay with EU and US yield curve endpoints getting replaced with this one?

@minhhoang1023
Copy link
Contributor

@IgorWounds looks good to me. Can you please let @montezdesousa know as we need to deprecate those in Excel too.

@montezdesousa
Copy link
Contributor

montezdesousa commented May 21, 2024

@IgorWounds looks good to me. Can you please let @montezdesousa know as we need to deprecate those in Excel too.

The changes are automatic once pro api updates and we redeploy Excel. Though we cannot send warnings in Excel

Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delivers!
image

@hjoaquim hjoaquim added this pull request to the merge queue May 21, 2024
Merged via the queue into develop with commit 8baf4d7 May 21, 2024
9 checks passed
@hjoaquim hjoaquim deleted the feature/yield-curve branch May 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants