[BUG][Go-server] attempt to fix the controller-api mustache template for a nullable bodyParam #20478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the generated code for
go-server
, in the Controller operation method, a BodyParam is defined as a simple variable. If that is also a Nullable field, the service takes it as a pointer parameter. But the call was made without.(I tried initially checking just for Nullable, but that broke other things. I'm not sure about the intricate logic here, so would appreciate someone's help to make sure my proposed fix is correct for all cases. For my case of the 5G APIs for Npcf PolicyAuthorization (link is to the bodyParam with the problem) seems to fix the issue.)
Also the examples here seem to be fine now, but I guess that my use case wasn't really covered, since my change does not change any generated code of the examples here. @wing328 I need your help again please and thank you 😜
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5