Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Go-server] attempt to fix the controller-api mustache template for a nullable bodyParam #20478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vingarzan
Copy link
Contributor

In the generated code for go-server, in the Controller operation method, a BodyParam is defined as a simple variable. If that is also a Nullable field, the service takes it as a pointer parameter. But the call was made without.

(I tried initially checking just for Nullable, but that broke other things. I'm not sure about the intricate logic here, so would appreciate someone's help to make sure my proposed fix is correct for all cases. For my case of the 5G APIs for Npcf PolicyAuthorization (link is to the bodyParam with the problem) seems to fix the issue.)

Also the examples here seem to be fine now, but I guess that my use case wasn't really covered, since my change does not change any generated code of the examples here. @wing328 I need your help again please and thank you 😜

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

@vingarzan vingarzan changed the title go-server: attempt to fix the controller-api mustache template for a nullable bodyParam [go-server] attempt to fix the controller-api mustache template for a nullable bodyParam Jan 15, 2025
@vingarzan vingarzan changed the title [go-server] attempt to fix the controller-api mustache template for a nullable bodyParam [BUG][Go-server] attempt to fix the controller-api mustache template for a nullable bodyParam Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant