Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended resources alignment wrt issue #106 #121

Merged
merged 1 commit into from
May 19, 2024
Merged

recommended resources alignment wrt issue #106 #121

merged 1 commit into from
May 19, 2024

Conversation

bhumika-1127
Copy link
Contributor

@Aryainguz Sorry to say that I am unable to solve the issue #106 as there were difference in the result page which was shown on your website https://euphoria-check-perma-meter-express.vercel.app/ and the result page which I open in my local repo. Unfortunately I was unable to find why it was showing like that underneath are the ss for both the pages.

on your website
image

on my local repo
Screenshot 2024-05-18 145953

But while going through your repo I found an issue of misalignment of "recommended recourses" section where the content was overflowing. So I fixed it instead. Kindly consider this contribution under GSSOC'24. Thank you, hope you will understand.
before
Screenshot 2024-05-18 150243
after
Screenshot 2024-05-18 150818

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @bhumika-1127! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Aryainguz Aryainguz merged commit dda9f87 into Open-Source-Chandigarh:main May 19, 2024
1 check passed
@bhumika-1127
Copy link
Contributor Author

bhumika-1127 commented May 19, 2024

Thank you for merging. kindly add the label for level also @Aryainguz

@bhumika-1127
Copy link
Contributor Author

@Aryainguz kindly add the label for level also, otherwise my contribution will not be counted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants