Step thread safety improvement #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtheneNoctuaPt
added
2. Bug
AtheneNoctuaPt
added a commit
to AtheneNoctuaPt/OCCT
that referenced
this pull request
Jan 30, 2025
Mutex is added to XSControl_WorkSession to prevent data races during reading and writing.
AtheneNoctuaPt
force-pushed
the
CR33657
branch
from
0ecd385 to
e0d8348
Compare
AtheneNoctuaPt
changed the title
AtheneNoctuaPt
added a commit
to AtheneNoctuaPt/OCCT
that referenced
this pull request
Jan 30, 2025
Mutex is added to XSControl_WorkSession to prevent data races during reading and writing.
AtheneNoctuaPt
force-pushed
the
CR33657
branch
from
e0d8348 to
518c875
Compare
dpasukhi
requested changes
Jan 30, 2025
| Handle(XSControl_Controller) myController; | ||
| Handle(XSControl_TransferReader) myTransferReader; | ||
| Handle(XSControl_TransferWriter) myTransferWriter; | ||
| XSControl_WorkSessionMap myContext; | ||
| Handle(XSControl_Vars) myVars; | ||
|
|
||
| static Standard_Mutex myGlobalMutex; //!< Mutex to prevent data races during reading and writing. |
There was a problem hiding this comment.
Please hide it into singleton inside CXX
AtheneNoctuaPt
added a commit
to AtheneNoctuaPt/OCCT
that referenced
this pull request
Jan 30, 2025
Mutex is added to XSControl_WorkSession to prevent data races during reading and writing. Tests are added to check the behavior of STEP readers/writers in multithreading environment.
AtheneNoctuaPt
force-pushed
the
CR33657
branch
from
518c875 to
9e6ec7d
Compare
AtheneNoctuaPt
added a commit
to AtheneNoctuaPt/OCCT
that referenced
this pull request
Jan 30, 2025
Mutex is added to XSControl_WorkSession to prevent data races during reading and writing. Tests are added to check the behavior of STEP readers/writers in multithreading environment.
AtheneNoctuaPt
force-pushed
the
CR33657
branch
from
9e6ec7d to
52c62ab
Compare
Mutex is added to XSControl_WorkSession to prevent data races during reading and writing. Tests are added to check the behavior of STEP readers/writers in multithreading environment.
AtheneNoctuaPt
force-pushed
the
CR33657
branch
from
52c62ab to
cc4607e
Compare
dpasukhi
changed the title
dpasukhi
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutex is added to XSControl_WorkSession to prevent data races during reading and writing.