Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed linting issues: Use method Error #68

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fixed linting issues: Use method Error #68

merged 1 commit into from
Sep 2, 2024

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Sep 2, 2024

Resolved linting error: printf: non-constant format string in call to github.com/sirupsen/logrus.Errorf (govet)

The Error method should be used instead of Errorf. The Errorf function expects format specifiers in the error message.

Copy link

github-actions bot commented Sep 2, 2024

Test Results

  6 files  ±0   54 suites  ±0   4s ⏱️ ±0s
160 tests ±0  160 ✅ ±0  0 💤 ±0  0 ❌ ±0 
960 runs  ±0  960 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d394a14. ± Comparison against base commit 0eaf9bd.

Copy link

codeclimate bot commented Sep 2, 2024

Code Climate has analyzed commit d394a14 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 60.0% (35% is the threshold).

This pull request will bring the total coverage in the repository to 36.9% (0.0% change).

View more on Code Climate.

@soumeh01 soumeh01 changed the title Linting issues use method Error Fixed linting issues: Use method Error Sep 2, 2024
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jkrech jkrech merged commit 6687f5e into main Sep 2, 2024
20 checks passed
@jkrech jkrech deleted the lintIssues branch September 13, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants