Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "name:" and "map:" node #52

Merged
merged 1 commit into from
May 16, 2024
Merged

Add support for "name:" and "map:" node #52

merged 1 commit into from
May 16, 2024

Conversation

DavidLesnjak
Copy link
Collaborator

@DavidLesnjak DavidLesnjak commented May 14, 2024

  • cbuild.go:
    • Independent of stm32CubeMX
    • Extend structure CbuildGenIdxType with "map" and "name"
    • Function Read returns parameters only for requested generatorID
  • stm32CubeMX.go:
    • Introduce structure BridgeParamType that contains only necessary information for CubeMX bridge
    • Determine CubeMX context (including new contexts, that are provided by new "map" node) and save it to BridgeParamType (CubeMX context is parsed only in one place)
  • mxDevice.go:
    • Simplify CubeMX context handling. CubeMX context is already provided as parameter in BridgeParamType
    • Change the *hal_msp.c file name retrival method. (old method does not work for STM32H7RS devices)
  • iniReader.go:
    • Simplify CubeMX context handling. CubeMX context is already provided as parameter in BridgeParamType
  • readFile.go:
    • synchronize to changes in cbuild.go, mxDevice.go and stm32CubeMx.go
  • Synchronize test files to changes in source files

Copy link

Test Results

  6 files  ± 0   54 suites  ±0   4s ⏱️ ±0s
160 tests  -  3  160 ✅  -  3  0 💤 ±0  0 ❌ ±0 
960 runs   - 18  960 ✅  - 18  0 💤 ±0  0 ❌ ±0 

Results for commit ae6bed1. ± Comparison against base commit eeb1e9b.

This pull request removes 3 tests.
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getDeviceFamily
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getDeviceFamily/fail
github.com/open-cmsis-pack/generator-bridge/internal/stm32CubeMX ‑ Test_getDeviceFamily/test

Copy link

codeclimate bot commented May 14, 2024

Code Climate has analyzed commit ae6bed1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 20.8% (35% is the threshold).

This pull request will bring the total coverage in the repository to 38.6% (2.0% change).

View more on Code Climate.

Copy link
Collaborator

@bgn42 bgn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokks like a complete rewrite of cbridge, I'll have a deeper look into it on wednesday.

@DavidLesnjak DavidLesnjak merged commit 46cffae into main May 16, 2024
20 checks passed
@DavidLesnjak DavidLesnjak deleted the new_nodes branch June 5, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance cbridge to read and consider new nodes in *.cbuild-gen-idx.yml
2 participants