Use public virtual destructor in isobus::CANHardwarePlugin #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to use classes such as `isobus::CANHardwarePlugin` polymophically C++ requires a `virtual` destructor in the base class. This ensures that, when the pointer to base is destroyed, that it will correctly call the derived destructors as well.
GwnDaan
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In order to be able to use classes such as
isobus::CANHardwarePluginpolymophically C++ requires a publicvirtualdestructor in the base class, otherwise the behaviour of the delete expression via pointer-to-base is undefined.This was picked up by my client's linter.
For reference, this check is enabled in Sonar but it seems to miss this file somehow.
Fixes # (issue)
No issue found in tracker.
How has this been tested?
Patch applied internally and linting no longer reportes this error.