Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VT]: Add Virtual Terminal Object Classes #346

Merged
merged 2 commits into from
Nov 25, 2023
Merged

[VT]: Add Virtual Terminal Object Classes #346

merged 2 commits into from
Nov 25, 2023

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Nov 10, 2023 •
edited
Loading

This is intended to be used with a VT server (coming soon? ) or with an object pool editor program. I wanted to open a PR for the ones I have done before the file gets even larger.

  • Added classes to represent most VT objects.

  • Todo: Unit tests

  • Todo: Get Attribute Value functions

Supported objects so far:

  • Working Set
  • Data Mask
  • Alarm Mask
  • Container
  • Soft Key mask
  • Key
  • Key Group
  • Button
  • Input Boolean
  • Input String
  • Input Number
  • Input List
  • Output String
  • Output Number
  • Output List
  • Output Line
  • Output Rectangle
  • Output Ellipse
  • Output Polygon
  • Output Meter
  • Output Linear Bar Graph
  • Output Arched Bar Graph
  • Picture Graphic
  • Number Variable
  • String Variable
  • Font Attributes
  • Line Attributes
  • Fill Attributes
  • Input Attributes
  • Extended Input Attributes
  • Object Pointer
  • External Object Pointer
  • Macro
  • Colour Map
  • Window Mask

@ad3154 ad3154 added the enhancement New feature or request label Nov 10, 2023
@ad3154 ad3154 self-assigned this Nov 10, 2023
@ad3154 ad3154 requested a review from GwnDaan November 10, 2023 18:36
@ad3154 ad3154 force-pushed the vt-object-pool-objects branch from 10d7a00 to 4bcf315 Compare November 11, 2023 03:22
@GwnDaan GwnDaan added the iso: virtual terminal Related to the ISO-11783:7 standard label Nov 11, 2023
@ad3154 ad3154 force-pushed the vt-object-pool-objects branch 3 times, most recently from cbb68ff to b08b553 Compare November 17, 2023 04:04
@ad3154 ad3154 force-pushed the vt-object-pool-objects branch 3 times, most recently from ac650fd to 20afb84 Compare November 19, 2023 20:15
@ad3154 ad3154 marked this pull request as ready for review November 19, 2023 20:29
@ad3154
Copy link
Member Author

ad3154 commented Nov 19, 2023

@GwnDaan I've finished my todos on this for now, so it's ready to review at your convenience.

Despite the amount of code, it's mostly just setters and getters for the various object types, so there's not really that much functionality to worry about. The object pool deserializer and whatnot will come in another PR.

@GwnDaan
Copy link
Member

GwnDaan commented Nov 19, 2023 •
edited
Loading

@GwnDaan I've finished my todos on this for now, so it's ready to review at your convenience.

Despite the amount of code, it's mostly just setters and getters for the various object types, so there's not really that much functionality to worry about. The object pool deserializer and whatnot will come in another PR.

Sounds good! I'll try to review it in the coming days, and then I think I'll just mainly have a look at the tests and not so much at the rest, as you suggested👍

@ad3154 ad3154 force-pushed the vt-object-pool-objects branch from 20afb84 to d497898 Compare November 21, 2023 16:43
@GwnDaan GwnDaan force-pushed the vt-object-pool-objects branch 2 times, most recently from 5a11091 to 20afb84 Compare November 21, 2023 16:55
@ad3154
[VT]: Add Virtual Terminal Object Classes
dbb635f 
Added classes to represent most VT objects.
This is intended to be used with a VT server (coming soon) or
with an object pool editor program.
@ad3154 ad3154 force-pushed the vt-object-pool-objects branch from 20afb84 to fc64508 Compare November 22, 2023 22:45
@ad3154
[VT]: Refactor VT objects
66c4d5d 
Removed stored references of the whole object tree to avoid dangling references.
Removed stored references to the working set's colour map, which should be held externally.
Moved some attributes from the child objects vector to instead be set and get
via dedicated functions to add clarity.
Also, improved error checking for some objects.
@ad3154 ad3154 force-pushed the vt-object-pool-objects branch from fc64508 to 66c4d5d Compare November 22, 2023 23:31
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 55 Code Smells

78.1% 78.1% Coverage
16.2% 16.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ad3154 ad3154 merged commit a084657 into main Nov 25, 2023
9 of 10 checks passed
@ad3154 ad3154 deleted the vt-object-pool-objects branch November 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbenso vbenso vbenso left review comments

@GwnDaan GwnDaan GwnDaan approved these changes

Assignees

@ad3154 ad3154

Labels
enhancement New feature or request iso: virtual terminal Related to the ISO-11783:7 standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ad3154 @GwnDaan @vbenso