[Meta]: Modernized setting the C++ version in CMake #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced setting CMAKE_CXX_STANDARD and CMAKE_CXX_STANDARD_REQUIRED with set_target_properties to avoid unintentionally affecting top level consuming projects.
ad3154
force-pushed
the
ca-adg/target-compile-options
branch
from
b7c96be to
a7b40a3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
GwnDaan
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_CXX_STANDARDandCMAKE_CXX_STANDARD_REQUIREDwithset_target_propertiesto avoid unintentionally affecting top level consuming projects.This seems like it's the more modern way of setting the version so as to not affect the global C++ settings in a consuming project.