Cleanup - iOS misc RCTOneSignal (Needs testing) #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OneSignal only support iOS 9 and newer
* This now setup in RCT_EXPORT_METHOD(setNotificationOpenedHandler) so this is dead code * rm supporting jsonObjectWithString method as this is now dead code * rm coldStartOSNotificationOpenedResult as it was never used
* This is used anywhere. * Not related to RCTOneSignalEventEmitter's _didStartObserving
* RCTOneSignal never uses NSNotificationCenter, removeObserver is dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is to clean up some iOS dead code in RCTOneSignal that was moved to OneSignalEventEmitter. This was confusing when looking at this SDK a reference of how it handles notification opens from cold start. Noticed a few other things while in this file.
Testing
I have not tested this. Before merging we this needs to be done. The next time I run react native I will test a notification open cold start.
This change is