Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - iOS misc RCTOneSignal (Needs testing) #1196

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Apr 10, 2021

Motivation

This is to clean up some iOS dead code in RCTOneSignal that was moved to OneSignalEventEmitter. This was confusing when looking at this SDK a reference of how it handles notification opens from cold start. Noticed a few other things while in this file.

Testing

I have not tested this. Before merging we this needs to be done. The next time I run react native I will test a notification open cold start.

This change is Reviewable

* OneSignal only support iOS 9 and newer
* This now setup in
RCT_EXPORT_METHOD(setNotificationOpenedHandler) so this is dead code
* rm supporting jsonObjectWithString method as this is now dead code
* rm coldStartOSNotificationOpenedResult as it was never used
* This is used anywhere.
* Not related to RCTOneSignalEventEmitter's _didStartObserving
* RCTOneSignal never uses NSNotificationCenter,  removeObserver is
dead code
Copy link
Contributor

@kesheshyan kesheshyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brakes the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants