[wip] ci

.github/workflows/ci.yml

@@ -40,7 +40,7 @@ jobs:
       - name: Test
         env:
           scheme: ${{ 'UnitTestApp' }}
-          test_plan: ${{ 'UnitTestApp_TestPlan_Reduced' }}
+          test_plan: ${{ 'UnitTestPlan_TestPlan_BadgeOnly' }}
           platform: ${{ 'iOS Simulator' }}
           file_to_build: ${{ 'iOS_SDK/OneSignalSDK/OneSignal.xcodeproj' }}
           filetype_parameter: ${{ 'project' }}

iOS_SDK/OneSignalDevApp/OneSignalDevApp/AppDelegate.m

@@ -50,7 +50,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
 
 //    [FIRApp configure];
 
-    NSLog(@"Bundle URL: %@", [[NSBundle mainBundle] bundleURL]);
+    NSLog(@"    Bundle URL: %@", [[NSBundle mainBundle] bundleURL]);
     [OneSignal.Debug setLogLevel:ONE_S_LL_VERBOSE];
     [OneSignal.Debug setAlertLevel:ONE_S_LL_NONE];
 

iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/xcshareddata/xcschemes/UnitTestApp.xcscheme

@@ -151,6 +151,9 @@
          <TestPlanReference
             reference = "container:UnitTestApp/UnitTestApp_TestPlan_Reduced.xctestplan">
          </TestPlanReference>
+         <TestPlanReference
+            reference = "container:UnitTestApp/UnitTestPlan_TestPlan_BadgeOnly.xctestplan">
+         </TestPlanReference>
       </TestPlans>
       <Testables>
          <TestableReference
@@ -213,6 +216,16 @@
                ReferencedContainer = "container:OneSignal.xcodeproj">
             </BuildableReference>
          </TestableReference>
+         <TestableReference
+            skipped = "NO">
+            <BuildableReference
+               BuildableIdentifier = "primary"
+               BlueprintIdentifier = "DEBA2A192C20E35E00E234DB"
+               BuildableName = "OneSignalNotificationsTests.xctest"
+               BlueprintName = "OneSignalNotificationsTests"
+               ReferencedContainer = "container:OneSignal.xcodeproj">
+            </BuildableReference>
+         </TestableReference>
       </Testables>
    </TestAction>
    <LaunchAction

iOS_SDK/OneSignalSDK/OneSignalNotifications/OSNotificationsManager.m

@@ -260,8 +260,10 @@ + (void)start {
 + (void)registerLifecycleObserver {
     // Replacing swizzled lifecycle selectors with notification center observers for scene based Apps
     if ([OSBundleUtils isAppUsingUIScene]) {
+        NSLog(@"💛 registerLifecycleObserverAs UIScene ");
         [self registerLifecycleObserverAsUIScene];
     } else {
+        NSLog(@"💛 registerLifecycleObserverAs UIApplication ");
         [self registerLifecycleObserverAsUIApplication];
     }
 }

iOS_SDK/OneSignalSDK/OneSignalNotificationsTests/OneSignalNotificationsTests.swift

@@ -31,6 +31,8 @@ final class OneSignalNotificationsTests: XCTestCase {
     var token: String = ""
 
     override func setUpWithError() throws {
+        // Temp. logging to help debug during testing
+        OneSignalLog.setLogLevel(.LL_VERBOSE)
         // Put setup code here. This method is called before the invocation of each test method in the class.
         self.notifTypes = 0
         self.token = ""
@@ -40,10 +42,11 @@ final class OneSignalNotificationsTests: XCTestCase {
         // Put teardown code here. This method is called after the invocation of each test method in the class.
     }
 
-    func testClearBadgesWhenAppEntersForeground() throws {
+    func testClearBadgesWhenAppEntersForeground() throws { // Fails when running alone
         // NotificationManager Start to register lifecycle listener
         OSNotificationsManager.start()
         // Set badge count > 0
+        print("💛 testClearBadgesWhenAppEntersForeground setting applicationIconBadgeNumber")
         UIApplication.shared.applicationIconBadgeNumber = 1
         // Then background the app
         OneSignalCoreMocks.backgroundApp()
@@ -53,10 +56,11 @@ final class OneSignalNotificationsTests: XCTestCase {
         XCTAssertEqual(UIApplication.shared.applicationIconBadgeNumber, 0)
     }
 
-    func testDontclearBadgesWhenAppBecomesActive() throws {
+    func testDontclearBadgesWhenAppBecomesActive() throws { // Unable to make it fail alone
         // NotificationManager Start to register lifecycle listener
         OSNotificationsManager.start()
         // Set badge count > 0
+        print("💛 testDontclearBadgesWhenAppBecomesActive setting applicationIconBadgeNumber")
         UIApplication.shared.applicationIconBadgeNumber = 1
         // Then resign active
         OneSignalCoreMocks.resignActive()
@@ -65,6 +69,58 @@ final class OneSignalNotificationsTests: XCTestCase {
         // Ensure that badge count == 1
         XCTAssertEqual(UIApplication.shared.applicationIconBadgeNumber, 1)
     }
+//    
+//    func testClearBadgesWhenAppEntersForeground1() throws {
+//        // NotificationManager Start to register lifecycle listener
+//        OSNotificationsManager.start()
+//        // Set badge count > 0
+//        UIApplication.shared.applicationIconBadgeNumber = 1
+//        // Then background the app
+//        OneSignalCoreMocks.backgroundApp()
+//        // Foreground the app
+//        OneSignalCoreMocks.foregroundApp()
+//        // Ensure that badge count == 0
+//        XCTAssertEqual(UIApplication.shared.applicationIconBadgeNumber, 0)
+//    }
+//
+//    func testDontclearBadgesWhenAppBecomesActive2() throws {
+//        // NotificationManager Start to register lifecycle listener
+//        OSNotificationsManager.start()
+//        // Set badge count > 0
+//        UIApplication.shared.applicationIconBadgeNumber = 1
+//        // Then resign active
+//        OneSignalCoreMocks.resignActive()
+//        // App becomes active the app
+//        OneSignalCoreMocks.becomeActive()
+//        // Ensure that badge count == 1
+//        XCTAssertEqual(UIApplication.shared.applicationIconBadgeNumber, 1)
+//    }
+//    
+//    func testClearBadgesWhenAppEntersForeground3() throws {
+//        // NotificationManager Start to register lifecycle listener
+//        OSNotificationsManager.start()
+//        // Set badge count > 0
+//        UIApplication.shared.applicationIconBadgeNumber = 1
+//        // Then background the app
+//        OneSignalCoreMocks.backgroundApp()
+//        // Foreground the app
+//        OneSignalCoreMocks.foregroundApp()
+//        // Ensure that badge count == 0
+//        XCTAssertEqual(UIApplication.shared.applicationIconBadgeNumber, 0)
+//    }
+//
+//    func testDontclearBadgesWhenAppBecomesActive4() throws {
+//        // NotificationManager Start to register lifecycle listener
+//        OSNotificationsManager.start()
+//        // Set badge count > 0
+//        UIApplication.shared.applicationIconBadgeNumber = 1
+//        // Then resign active
+//        OneSignalCoreMocks.resignActive()
+//        // App becomes active the app
+//        OneSignalCoreMocks.becomeActive()
+//        // Ensure that badge count == 1
+//        XCTAssertEqual(UIApplication.shared.applicationIconBadgeNumber, 1)
+//    }
 
     func testUpdateNotificationTypesOnAppEntersForeground() throws {
         // NotificationManager Start to register lifecycle listener

iOS_SDK/OneSignalSDK/UnitTestApp/UnitTestPlan_TestPlan_BadgeOnly.xctestplan

@@ -0,0 +1,24 @@
+{
+  "configurations" : [
+    {
+      "id" : "0F56CD0B-5904-415C-B328-24EE0394B75B",
+      "name" : "Configuration 1",
+      "options" : {
+
+      }
+    }
+  ],
+  "defaultOptions" : {
+    "testTimeoutsEnabled" : true
+  },
+  "testTargets" : [
+    {
+      "target" : {
+        "containerPath" : "container:OneSignal.xcodeproj",
+        "identifier" : "DEBA2A192C20E35E00E234DB",
+        "name" : "OneSignalNotificationsTests"
+      }
+    }
+  ],
+  "version" : 1
+}