Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide #1305

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Update migration guide #1305

merged 2 commits into from
Aug 11, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Aug 11, 2023

Description

One Line Summary

Improve the migration guide to call out modular import and setLaunchURLsInApp removal

Details

Fixes #1304
Explains how to use modular import for SwiftPM and Cocoapods

Motivation

improve migration guide

Testing

Manual testing

preview rendered in VSCode with Github Markdown extension

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby requested a review from jkasten2 August 11, 2023 15:42
@emawby emawby merged commit 560b5bb into major_release_5.0.0 Aug 11, 2023
1 of 2 checks passed
@emawby emawby deleted the update_migration_guide branch August 11, 2023 15:47
nan-li pushed a commit that referenced this pull request Oct 30, 2023
nan-li pushed a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants