Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User model] Web view inspectability #1299

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Aug 10, 2023

Description

One Line Summary

Enable inspectability of webviews if the log level is debug or greater

Details

Cherry-pick of #1286 and #1292

We build using iOS 14.1 which does not support webview.inspectable = true

We will use reflection to only call the method if the device supports it. Additionally since the method has a boolean argument we must use NSInvocation instead of performSelector

I also split the @available check with the debug check since they cannot be in the same statement.

Scope

IAMs in debug mode

Testing

Unit testing

OPTIONAL - Explain unit tests added, if not clear in the code.

Manual testing

Tested IAM display on simulator

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

We build using iOS 14.1 which does not support webview.inspectable = true

We will use reflection to only call the method if the device supports it. Additionally since the method has a boolean argument we must use NSInvocation instead of performSelector

I also split the @available check with the debug check since they cannot be in the same statement.
@emawby emawby changed the base branch from main to major_release_5.0.0 August 10, 2023 03:25
@emawby emawby merged commit fa82ce5 into major_release_5.0.0 Aug 10, 2023
@emawby emawby deleted the user_model/web_view_inspectability branch August 10, 2023 03:29
nan-li pushed a commit that referenced this pull request Oct 30, 2023
…ility

[User model] Web view inspectability
nan-li pushed a commit that referenced this pull request Oct 30, 2023
…ility

[User model] Web view inspectability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants