Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add Amazon IAP v3.0.5 handle #2255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jetie000
Copy link

@jetie000 jetie000 commented Feb 4, 2025

Description

Added Amazon IAP v3.0.5 handle

Details

I'm developing app for business and faced this error while integrating
[email protected]
Error appeared because I also use @revenuecat/[email protected] (versions between 8.0.0 and 9.2.1 use Amazon IAP v3.0.5)
So Amazon IAP v3.0.5 is downloaded and we can't access method at class com.amazon.device.iap.internal.d
line:

Error screenshot:

image

This method at v3.0.4

image

This method at v3.0.5

image

Manual testing

Steps:

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant