-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of ryw_delay
to minimize retries on IAM fetch
#2207
base: main
Are you sure you want to change the base?
Commits on Oct 24, 2024
-
Encapsulate
rywToken
&rywDelay
inRywData
data class objectMotivation: we need to keep the two values together in order to know how much to delay by (based on what rywToken is newest)
Configuration menu - View commit details
-
Copy full SHA for e6bfb3a - Browse repository at this point
Copy the full SHA e6bfb3aView commit details -
Nit: rename method for clarity
Motivation: it's unclear from the previous method name that we are expecting something to be returned.
Configuration menu - View commit details
-
Copy full SHA for 251976b - Browse repository at this point
Copy the full SHA 251976bView commit details -
Delay the IAM fetch by
rywDelay
w/ fallbackMotivation: make use of the new object to pull out the `rywDelay` value & delay by that amount. By doing so we help minimize the number of retries that will hit the backend.
Configuration menu - View commit details
-
Copy full SHA for 8b79aac - Browse repository at this point
Copy the full SHA 8b79aacView commit details
Commits on Oct 25, 2024
-
Use
RywData
everywhere we were previously usingString
(rywToken
)Motivation: update all usages of `rywToken` to now make use of the new `RywData` object. In `ConsistencyManager` we also renamed the method `setRywToken` to `setRywData`
Configuration menu - View commit details
-
Copy full SHA for bb4a0b7 - Browse repository at this point
Copy the full SHA bb4a0b7View commit details
Commits on Oct 30, 2024
-
Rename
getNewestToken
togetRywData
for clarityMotivation: we switched to return a RywData object so method name didn't make sense any more
Configuration menu - View commit details
-
Copy full SHA for 2ad40bf - Browse repository at this point
Copy the full SHA 2ad40bfView commit details -
Add note on why lexicographic evaluation works for RYW tokens
Motivation: add clarity on why the method maxOrNull (which uses lexicographic evaulation for strings) works for this use case.
Configuration menu - View commit details
-
Copy full SHA for 1329416 - Browse repository at this point
Copy the full SHA 1329416View commit details -
Configuration menu - View commit details
-
Copy full SHA for 592cca2 - Browse repository at this point
Copy the full SHA 592cca2View commit details -
Update RywData usage so
rywToken
is non-nullMotivation: rywData shouldn't be considered a valid rywData object if rywToken is undefined. We update usage across the board to account for this type change.
Configuration menu - View commit details
-
Copy full SHA for f6e4a90 - Browse repository at this point
Copy the full SHA f6e4a90View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec5e3dd - Browse repository at this point
Copy the full SHA ec5e3ddView commit details