Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of ryw_delay to minimize retries on IAM fetch #2207

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Oct 24, 2024

  1. Encapsulate rywToken & rywDelay in RywData data class object

    Motivation: we need to keep the two values together in order to know how much to delay by (based on what rywToken is newest)
    rgomezp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e6bfb3a View commit details
    Browse the repository at this point in the history
  2. Nit: rename method for clarity

    Motivation: it's unclear from the previous method name that we are expecting something to be returned.
    rgomezp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    251976b View commit details
    Browse the repository at this point in the history
  3. Delay the IAM fetch by rywDelay w/ fallback

    Motivation: make use of the new object to pull out the `rywDelay` value & delay by that amount.
    
    By doing so we help minimize the number of retries that will hit the backend.
    rgomezp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8b79aac View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Use RywData everywhere we were previously using String (rywToken)

    Motivation: update all usages of `rywToken` to now make use of the new `RywData` object.
    
    In `ConsistencyManager` we also renamed the method `setRywToken` to `setRywData`
    rgomezp committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bb4a0b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Rename getNewestToken to getRywData for clarity

    Motivation: we switched to return a RywData object so method name didn't make sense any more
    rgomezp committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2ad40bf View commit details
    Browse the repository at this point in the history
  2. Add note on why lexicographic evaluation works for RYW tokens

    Motivation: add clarity on why the method maxOrNull (which uses lexicographic evaulation for strings) works for this use case.
    rgomezp committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1329416 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    592cca2 View commit details
    Browse the repository at this point in the history
  4. Update RywData usage so rywToken is non-null

    Motivation: rywData shouldn't be considered a valid rywData object if rywToken is undefined.
    
    We update usage across the board to account for this type change.
    rgomezp committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f6e4a90 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ec5e3dd View commit details
    Browse the repository at this point in the history