Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix ada message sign and update static resource #567

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

somebodyLi
Copy link
Contributor

No description provided.

@somebodyLi somebodyLi requested a review from a team as a code owner July 17, 2024 07:16
Copy link

what-the-diff bot commented Jul 17, 2024

PR Summary

  • Enhanced Cardano Transaction Signatures
    The capability of the Cardano transaction message has been expanded to include an optional CardanoAddressType, which provides more flexibility in handling different types of Cardano addresses.

  • Improved Message Signing Logic
    The message signature mechanism in sign_message.py has been enhanced to handle different Cardano address type values. It also now uses a more efficient method for encoding address bytes for readability. We have also deleted unused elements to keep the module clean and efficient.

  • UI Adjustment
    An adjustment was made to broaden the label1 and label2 sections in app_guide.py, improving the interface visibility.

  • Extended Cardano Message Capabilities
    The CardanoSignMessage function now also supports the optional CardanoAddressType field, adding more versatility in handling Cardano messages.

  • No Changes to Image Assets
    There haven't been any changes made to the download.png image.

@somebodyLi somebodyLi enabled auto-merge (squash) July 17, 2024 07:30
@somebodyLi somebodyLi disabled auto-merge July 17, 2024 07:32
@somebodyLi somebodyLi enabled auto-merge (squash) July 17, 2024 07:34
@somebodyLi somebodyLi merged commit b025839 into OneKeyHQ:touch Jul 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants