Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linkedin url for extracting information #44

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

umitdincel
Copy link

@umitdincel umitdincel commented Dec 18, 2020

It may be useful to add linkedin url to extracting information

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #44 (e4654df) into master (36f1242) will decrease coverage by 0.16%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   71.73%   71.57%   -0.17%     
==========================================
  Files           5        5              
  Lines         368      380      +12     
==========================================
+ Hits          264      272       +8     
- Misses        104      108       +4     
Impacted Files Coverage Δ
pyresparser/utils.py 64.46% <42.85%> (-0.65%) ⬇️
pyresparser/resume_parser.py 76.19% <100.00%> (+0.58%) ⬆️
test_name.py 94.73% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f1242...e4654df. Read the comment docs.

@OmkarPathak
Copy link
Owner

@umitdincel it would be great if you add tests for this

@umitdincel
Copy link
Author

@OmkarPathak Added but it doesn't match your linkedin caption so is it possible to update it as full link?

@OmkarPathak
Copy link
Owner

@umitdincel it seems you have not tested the test that you wrote, go through the logs here: https://travis-ci.com/github/OmkarPathak/pyresparser/builds/211156947

@umitdincel
Copy link
Author

The build passed but the coverage looks like a little bit reduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants