Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Community Files and Defined Folder Organization Structure. #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ansh-Sarkar
Copy link

Community Files and Docs

  • Added : CONTRIBUTIONS.md , docs/README.md, ISSUE_TEMPLATES, .github, PR_TEMPLATES, CODE_OF_CONDUCT.md
  • Modified : README.md, src/data_structures/sparse_table/README.md

Documentation Added

  • Added : Implementation of DSU : disjoint_sets_union/README.md

#5

@@ -0,0 +1,45 @@
# Prerequisites

```Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.**```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why surrounding most of the lines with back ticks? That way, they will appear as code snippets.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. I just felt that they appear cleaner when seen in MarkDown Preview. So that's why. But sure I'll remove them. Do you want them to be removed from all the places apart from where they represent actual Code Snippets ?

Comment on lines +5 to +8
- [ ] I am running the latest version
- [ ] I checked the documentation and found no answer
- [ ] I checked to make sure that this issue has not already been filed
- [ ] I'm reporting the issue to the correct repository (for multi-repository projects)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change these statements to questions as you mentioned above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I don't think I got that properly. Like, by questions do you mean something like :

  • Are you running the latest version ?
  • Have you already checked out the documentation and were unable to find an answer ?
  • and so on . . .

Is this the expected format ?


```Please provide detailed steps for reproducing the issue.```

1. step 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the same casing: use "Step" (with capital S).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure. I'll fix this.

@OmarBazaraa
Copy link
Owner

Thanks @Ansh-Sarkar for your contribution. It will take me some time before reviewing the PR.

@Ansh-Sarkar
Copy link
Author

Thanks @Ansh-Sarkar for your contribution. It will take me some time before reviewing the PR.

Sure. I'll complete the changes and update the PR as soon as you finish reviewing and are happy with the proposed changes.

@Ansh-Sarkar
Copy link
Author

@OmarBazaraa Do you think we should add a LICENSE.md file to this repo as well ?

@Ansh-Sarkar
Copy link
Author

@OmarBazaraa . Did you get a chance to have a look at this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants