Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance privacy page #219

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Conversation

Frpratik
Copy link
Contributor

@Frpratik Frpratik commented Feb 1, 2025

Related Issue

Fixes #[IssueNumber]

Description

[Please include a brief description of the changes or features added]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scd-profile-score ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 9:02am

Copy link

github-actions bot commented Feb 1, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Frpratik
Copy link
Contributor Author

Frpratik commented Feb 1, 2025

Fixed logo rendering issue and some HTML page URL issues. @Ojas-Arora Please review it and merge it.

Copy link
Owner

@Ojas-Arora Ojas-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Ojas-Arora Ojas-Arora merged commit 3460e02 into Ojas-Arora:main Feb 1, 2025
3 checks passed
@Frpratik
Copy link
Contributor Author

Frpratik commented Feb 1, 2025

Bro, you have added a beginner label to it, but could you please please clarify? is it only for fixing the logo or for full ui improvements?

@Ojas-Arora
Copy link
Owner

@Frpratik File Changes has only the code for teh Fixation of Logo.

@Frpratik
Copy link
Contributor Author

Frpratik commented Feb 1, 2025

I have resolved two issues here one is an enhancement in ui for full page and another one which was not part of this issue, fixing logo rendering. so how would I get points for both? ui one was intermediate and this one is beginner.

@Ojas-Arora
Copy link
Owner

@Frpratik I have added extra points in another Pr .

@Frpratik
Copy link
Contributor Author

Frpratik commented Feb 1, 2025

okay, bro. do whatever you think is better. thank you, bro.

@Ojas-Arora Ojas-Arora added the done label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants