Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pretty links for citizens and teams #245

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Added pretty links for citizens and teams #245

merged 8 commits into from
Nov 11, 2024

Conversation

namedotget
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for moondao-stc canceled.

Name Link
🔨 Latest commit 8c39288
🔍 Latest deploy log https://app.netlify.com/sites/moondao-stc/deploys/67324ae3b7589d0008c3c848

@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for moondao-ce-demo ready!

Name Link
🔨 Latest commit 8c39288
🔍 Latest deploy log https://app.netlify.com/sites/moondao-ce-demo/deploys/67324ae30d9f9500080d3b12
😎 Deploy Preview https://deploy-preview-245--moondao-ce-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pmoncada
pmoncada requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@pmoncada pmoncada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - Looks great!

The only thingg that I'd add would be good to add some unit tests. In particular around checking that it generates a unique ID if there's a clash between pretty links / other potential corner cases with the pretty links

pmoncada
pmoncada requested changes Nov 8, 2024
View reviewed changes
ui/pages/network.tsx Show resolved Hide resolved
pmoncada
pmoncada approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@pmoncada pmoncada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - it's too bad all the links will now have a number, but I think this method makes things more straightforward on our end.

@namedotget namedotget merged commit 25e37fb into main Nov 11, 2024
7 of 9 checks passed
@namedotget namedotget deleted the ng-pretty-links branch November 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmoncada pmoncada pmoncada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namedotget @pmoncada