Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Programmatically access the "real" App ID and Manifest Version #2694

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MengyiGong
Copy link
Contributor

@MengyiGong MengyiGong commented Jan 22, 2025

For more information about how to contribute to this repo, visit this page.

Description

Adding the appId and manifestVersion to AppInfo so app can get appId and manifestVersion from getContext() API.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Added appId?: AppId
  2. Add manifestVersion?: string
Screenshot 2025-01-23 at 4 18 59 PM

@MengyiGong MengyiGong requested a review from a team as a code owner January 22, 2025 22:43
*
* @beta
*/
appId?: AppId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this property is an object of type AppId (which it should be! 😉), does there need to be code somewhere which deserializes the value when it comes from the host SDK (as a string) and turns it into an AppId object?

Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@MengyiGong MengyiGong force-pushed the maggieg/add_real_appId branch from 0557e33 to 60b07ac Compare January 23, 2025 21:32
@MengyiGong MengyiGong changed the title [WIP][Task 9077652 ] Programmatically access the "real" App ID and Manifest Version [Task] Programmatically access the "real" App ID and Manifest Version Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants