Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bot tag mention sample - Csharp #1534

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

Jegadeesh-MSFT
Copy link
Contributor

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • samples/bot-tag-mention/csharp/TeamsApp/aad.manifest.json: Language not supported
  • samples/bot-tag-mention/csharp/TeamsApp/appPackage/manifest.json: Language not supported
  • samples/bot-tag-mention/csharp/TeamsApp/infra/azure.bicep: Language not supported
Comments suppressed due to low confidence (1)

samples/bot-tag-mention/csharp/AdapterWithErrorHandler.cs:36

  • The comment contains a minor grammatical error. It should be corrected to: 'Uncomment below commented line for local debugging.'
// Uncomment below commented line for local debugging..
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, approving! only one comment please fix before merging

{
"url": "https://token.botframework.com/.auth/web/redirect",
"type": "Web"
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct alignment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Pawank-MSFT
Copy link
Collaborator

Pawank-MSFT commented Jan 30, 2025

Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good Approved !

@Pawank-MSFT Pawank-MSFT merged commit 3718cea into main Jan 30, 2025
273 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants