Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to dotnet 8, drop startup.cs and use CloudAdapter #1518

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update to dotnet 8, drop startup.cs and use CloudAdapter #1518

wants to merge 2 commits into from

Conversation

kengibous
Copy link

  • use dotnet 8
  • drop startup.cs
  • use CloudApdater instead of BotFrameworkHttpAdapter (deprecated)

@kengibous
Copy link
Author

@microsoft-github-policy-service agree

Pawank-MSFT
Pawank-MSFT approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, approving!

Copilot
Copilot AI reviewed Jan 13, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • samples/bot-receive-channel-messages-withRSC/csharp/ReceiveMessagesWithRSC/ReceiveMessagesWithRSC.csproj: Language not supported

...ot-receive-channel-messages-withRSC/csharp/ReceiveMessagesWithRSC/AdapterWithErrorHandler.cs
public AdapterWithErrorHandler(
IConfiguration configuration,
IHttpClientFactory httpClientFactory,
ILogger<IBotFrameworkHttpAdapter> logger)
Copy link
Preview

Copilot AI Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logger type should be ILogger instead of ILogger.

Suggested change
ILogger<IBotFrameworkHttpAdapter> logger)
ILogger<CloudAdapter> logger)

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Pawank-MSFT Pawank-MSFT Pawank-MSFT approved these changes

@Wajeed-msft Wajeed-msft Awaiting requested review from Wajeed-msft

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kengibous @Pawank-MSFT