-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeboost mode for nitro-testnode #95
Open
Tristan-Wilson
wants to merge
24
commits into
master
Choose a base branch
from
timeboost-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+271
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a command for deploying the ExpressLaneAuction contract: docker compose run scripts deploy-express-lane-auction Since the contracts branch with ExpressLaneAuction is not published to NPM this commit adds a way for it to be included from the local workspace into the scripts docker image with the --dev-contracts flag. The bash and docker logic here needs to be cleaned up so that it will use the NPM version when not using the --dev-contracts flag. The commit includes WIP code for initializing the contract.
Open ports and set up auth endpoint correctly on sequencer. Deploy auction contract with l2owner instead of auctioneer accounts (admin account on proxy contract cannot make calls on the proxied-to contract).
The default value in nitro should work.
Changed the recommended nitro branch to |
Even if using an nitro image that doesn't have timeboost enabled yet, nitro will still start after logging an error message. Unavailable modules in HTTP API list unavailable=[timeboost] available="[admin debug web3 eth txpool personal net arb arbdebug arbtrace]"
ReserveSubmissionSeconds represents a period BEFORE the auction closes that the reserve price may be updated for the next round. The previous setting of 45 seconds means that the reserve price could not be updated at all after the round started, coupled with the auction closing period of 15 seconds (round duration is 60 seconds).
Instructions updated for latest nitro |
gzeoneth
reviewed
Nov 26, 2024
gzeoneth
reviewed
Nov 26, 2024
… is enabled (required for timeboost)
…flag' into timeboost-mode
Advertise http port instead of ws port to sequencer coordinator. Only the http APIs are configured in the docker-compose.yaml so it behaves more like you would expect. Restart all initial sequencers instead of just "sequencer" when setting up timeboost.
Also remove jwt token for auctioneer api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for timeboost mode on nitro-testnode. It starts the bid-validator, autonomous auctioneer, deploys the ExpressLaneAuction contract, and starts the sequencer in Timeboost mode.
Since Timeboost is not yet merged into the master nitro branch, currently you will need to follow the following steps to run nitro-testnode in Timeboost mode. (If you had followed these instructions before note that this now no longer requires special steps with the nitro-contracts package as a version with timeboost is now released.)
./test-node.bash --init-force --dev --l2-timeboost
When starting up, look for the line printing the token and contract address:
You can also find the auction contract and auctioneer address with the following command.
Users alice and bob have been pre-funded with some of the bidding token on L2 and can be used right away.
Commands for sending express lane transactions will be provided in future, see implementation and spec .