-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new versions.json and update build and release workflow to use it #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevjt
reviewed
Sep 30, 2024
kevjt
reviewed
Oct 1, 2024
kevjt
reviewed
Oct 1, 2024
MissedTheMark
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
kevjt
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Kubernetes image caching, we realised that customers were unlikely to be receiving the latest version of the worker tools.
This is a problem as we have now added
curl
to the image (#1), for use as part of automatic upgrades, but due to the cached image, it may not be on the image when the agent goes to perform the upgrade.This is because we previous overwrote the image with the same tag, but just different contents.
This PR changes this to have a random 6 char hash suffix on all
main
tags, so the tag1.30
now is1.30-X5msD0
. This means that we can version/revise the container image and have a different tag.We are also now publishing a tag with all the versions of the tools in the tag, e.g.
kube1.31.4-helm3.16.1-pwsh7.4.5-X5msD0
This PR also changes the build and deployment process to be based on a
versions.json
file in the root of this repo, which now contains the versions of Kubectl we are build for, the Helm & Powershell versions, as well as the version considered "latest" (e.g. gets thelatest
tag) and also what revision we are up to.This means that releasing a new version is now a PR activity, rather than an adhoc workflow run