Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new versions.json and update build and release workflow to use it #3

Merged
merged 27 commits into from
Oct 1, 2024

Conversation

APErebus
Copy link
Contributor

@APErebus APErebus commented Sep 30, 2024

Due to Kubernetes image caching, we realised that customers were unlikely to be receiving the latest version of the worker tools.

This is a problem as we have now added curl to the image (#1), for use as part of automatic upgrades, but due to the cached image, it may not be on the image when the agent goes to perform the upgrade.

This is because we previous overwrote the image with the same tag, but just different contents.

This PR changes this to have a random 6 char hash suffix on all main tags, so the tag 1.30 now is 1.30-X5msD0. This means that we can version/revise the container image and have a different tag.

We are also now publishing a tag with all the versions of the tools in the tag, e.g. kube1.31.4-helm3.16.1-pwsh7.4.5-X5msD0

This PR also changes the build and deployment process to be based on a versions.json file in the root of this repo, which now contains the versions of Kubectl we are build for, the Helm & Powershell versions, as well as the version considered "latest" (e.g. gets the latest tag) and also what revision we are up to.

This means that releasing a new version is now a PR activity, rather than an adhoc workflow run

@APErebus APErebus marked this pull request as draft September 30, 2024 04:56
@APErebus APErebus marked this pull request as ready for review September 30, 2024 06:21
@APErebus APErebus marked this pull request as draft September 30, 2024 06:23
versions.json Show resolved Hide resolved
@APErebus APErebus marked this pull request as ready for review October 1, 2024 01:29
versions.json Outdated Show resolved Hide resolved
Copy link
Contributor

@MissedTheMark MissedTheMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

Copy link

@kevjt kevjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants