return promise from getData (#90)

* return promise from `getData` * remove redundant `console.error`
Oceans-1876 · Oct 9, 2023 · 1e50653 · 1e50653
1 parent 7d15660
commit 1e50653
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/app.tsx b/src/app.tsx
@@ -59,14 +59,14 @@ const App: FC = () => {
                     (stations) => {
                         dataActionDispatcher({ type: 'loadStations', stations });
                     },
-                    console.error
+                    () => undefined
                 ),
                 getData<SpeciesSummary[]>(
                     'species/all/?order_by=matched_canonical_full_name',
                     (species) => {
                         dataActionDispatcher({ type: 'updateAllSpecies', species });
                     },
-                    console.error
+                    () => undefined
                 )
             ]).then(() => {
                 setInitialized(true);

diff --git a/src/store/api.ts b/src/store/api.ts
@@ -2,11 +2,11 @@ import axios, { AxiosError } from 'axios';
 import { Dayjs } from 'dayjs';
 
 export const getData = <T>(endpoint: string, success: (data: T) => void, err: (error: Error | AxiosError) => void) => {
-    axios
+    return axios
         .get(`${window.API_PATH}/${endpoint}`)
         .then(({ data }) => success(data))
         .catch((error) => {
-            console.error();
+            console.error(error);
             err(error);
         });
 };