-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A more efficient way of updating tags + Scan current file only #584
base: master
Are you sure you want to change the base?
Conversation
I just tried to download the data for the plugin from your pull request and add it to Obsidian, but it always failed with the error "Failed to load Obsidian_to_anki". Is this not the entire code that you inserted in the test_vault? |
I think you didn't compile the code? |
Can you explain what do you mean with "compile"? |
Sorry for the late response, I'm on vacation. You need to run the build script from the package.json I think you could also use BRAT but I never tried it. |
Thank you, that is work! |
Did it work? |
Yes, it works very well! |
This pull request is just a more efficient way of updating tags (using updateNoteTags vs. removeTags + addTags). This speeds up the generation task, especially if you have a big vault (2k notes) and a lot of tags in Anki (64k cards with ~16k tags). Alltogehter It should prevent Anki from dying due to a big request-payload.
Moreover, I added a command to scan the current file only.
This should fix #565. Maybe helps on #428, #354, #326.