Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#129:Made Video Upload Functionality eminent #139

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

chahat99
Copy link
Contributor

@chahat99 chahat99 commented Oct 9, 2022

Description

Made the Video Upload functionality prominent by putting it in a rectangular box. The button is visible on hovering over the dropdown.
Issue Link: #129
Screenshot 2022-10-09 at 4 18 42 PM

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged
  • I have documented any changes if required in the docs.

@JBAhire
Copy link
Collaborator

JBAhire commented Oct 9, 2022

@chahat99 , will it be possible add a white rectangular box and put the upload video button inside it? More of a nit, we can take this up in subsequent PRs as well. Let me know.

@chahat99
Copy link
Contributor Author

chahat99 commented Oct 9, 2022

@chahat99 , will it be possible add a white rectangular box and put the upload video button inside it? More of a nit, we can take this up in subsequent PRs as well. Let me know.

Yes, it is possible. We can take that up in subsequent PRs.

@piyushroshan piyushroshan merged commit 9bd23cd into OWASP:develop Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants