Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft for the intro section of D06 [WIP] #38

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

draft for the intro section of D06 [WIP] #38

wants to merge 3 commits into from

Conversation

drwetter
Copy link
Collaborator

@drwetter drwetter commented Jan 2, 2021

No description provided.

@drwetter drwetter mentioned this pull request Jan 2, 2021
@Aut0R3V
Copy link

Aut0R3V commented Jan 2, 2021

This looks great. @drwetter can you give me a brief idea on what you're expecting for the "How Do I Prevent" section? Maybe I can put in some work there

D06 - Protect Secrets.md Outdated Show resolved Hide resolved
D06 - Protect Secrets.md Outdated Show resolved Hide resolved
D06 - Protect Secrets.md Outdated Show resolved Hide resolved
@drwetter
Copy link
Collaborator Author

drwetter commented Jan 4, 2021

This looks great. @drwetter can you give me a brief idea on what you're expecting for the "How Do I Prevent" section? Maybe I can put in some work there

I think it is smarter to start with other sections like 'Threat scenarios' and ' How can I find out?'. 'How do I prevent' is then the result of both.

Abusing ENV is a typical point. Bad examples for this and others are helpful.

@Aut0R3V
Copy link

Aut0R3V commented Jan 4, 2021

This looks great. @drwetter can you give me a brief idea on what you're expecting for the "How Do I Prevent" section? Maybe I can put in some work there

I think it is smarter to start with other sections like 'Threat scenarios' and ' How can I find out?'. 'How do I prevent' is then the result of both.

Abusing ENV is a typical point. Bad examples for this and others are helpful.

Sure thanks

D06 - Protect Secrets.md Outdated Show resolved Hide resolved
D06 - Protect Secrets.md Outdated Show resolved Hide resolved
D06 - Protect Secrets.md Outdated Show resolved Hide resolved
D06 - Protect Secrets.md Outdated Show resolved Hide resolved
@kamadorueda
Copy link

Hi, can we merge pull requests on a regular basis? This way other people could collaborate on building the same document without too much conflicts

By the way, I've found these to be sources of secrets leakage:

image

The last one's threat is when an attacker has access to stopped containers in the host, for instance in shared CI systems

@drwetter
Copy link
Collaborator Author

drwetter commented May 24, 2021

@kamadorueda : This PR is still open because it is not yet complete.

Yes, passing by env is a common mistake.

@kamadorueda
Copy link

@drwetter I just wanted to help writing a few sections

@lirantal
Copy link

lirantal commented May 25, 2021

Indeed. And, infact, I wrote in the Node.js version of the secure docker image building how to use secrets to properly pass secrets to images: https://cheatsheetseries.owasp.org/cheatsheets/NodeJS_Docker_Cheat_Sheet.html

@drwetter drwetter changed the title draft for the intro section of D06 draft for the intro section of D06 [WIP] May 25, 2021
@drwetter
Copy link
Collaborator Author

drwetter commented May 25, 2021

Thanks!

Github works with PRs as you probably know. :-) If you want something to be added which would be appreciated, please submit a PR. I clarified the structure of the ten points in the contribution guidelines and in the introduction which hopefully clarifies how it should look like.

For this specific point it should work if your PR is against the d06_intro branch. Otherwise I can open a dev branch and let things mature there. Let me know how we can work on this

@lirantal : I got a 404.

@lirantal
Copy link

@drwetter
Copy link
Collaborator Author

drwetter commented Jun 3, 2021

Okay thanks. Basically one has to go through this and add commits hereto (by "hereto" I don't mean necessarily D06 only. A helping hand for the broader scope would be great.

In general what I would suggest that is that I either create a dev branch where all commits which a development status can be merged into. Alternatively I create separate dev branches for each open Dxx item. Both would ease progress)

Pls let me what you think.

@drwetter drwetter closed this Jun 7, 2021
@drwetter drwetter deleted the d06_intro branch June 7, 2021 08:40
@drwetter drwetter restored the d06_intro branch June 7, 2021 08:42
@drwetter drwetter reopened this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants