-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments on blog #3195
Comments on blog #3195
Conversation
@DonnieBLT sir, can this be reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you please also add automated tests?
Sure sir. |
@DonnieBLT sir , i have corrected the codeql tests, do i need to add any changes in test_urls as well? |
Can you make new test files test_blog and test_issues to test the comments on each please? |
sure sir, on it. |
@DonnieBLT sir, I have added the test files. |
Looks good! Thank you ! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
* comments on blog added * on comments * pre * change * chages * changes * tests added * pre
fixes #3179
Tests added could be run by :