Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on blog #3195

Merged
merged 13 commits into from
Jan 8, 2025
Merged

Comments on blog #3195

merged 13 commits into from
Jan 8, 2025

Conversation

krrish-sehgal
Copy link
Contributor

@krrish-sehgal krrish-sehgal commented Jan 4, 2025

fixes #3179

Tests added could be run by :

  1. python manage.py collectstatic --noinput
  2. python manage.py test website.{test_name_file}
Screenshot 2025-01-05 at 1 28 11 AM

@krrish-sehgal krrish-sehgal changed the title Comments Comments on blog Jan 4, 2025
website/views/issue.py Fixed Show fixed Hide fixed
@krrish-sehgal
Copy link
Contributor Author

@DonnieBLT sir, can this be reviewed?

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you please also add automated tests?

@krrish-sehgal
Copy link
Contributor Author

Looks good! Can you please also add automated tests?

Sure sir.

@krrish-sehgal
Copy link
Contributor Author

@DonnieBLT sir , i have corrected the codeql tests, do i need to add any changes in test_urls as well?

@DonnieBLT
Copy link
Collaborator

Can you make new test files test_blog and test_issues to test the comments on each please?

@krrish-sehgal
Copy link
Contributor Author

Can you make new test files test_blog and test_issues to test the comments on each please?

sure sir, on it.

@krrish-sehgal
Copy link
Contributor Author

@DonnieBLT sir, I have added the test files.
Thanks.

@DonnieBLT
Copy link
Collaborator

Looks good! Thank you !

@DonnieBLT DonnieBLT merged commit 4747b9b into OWASP-BLT:main Jan 8, 2025
9 checks passed
Copy link

sentry-io bot commented Jan 9, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ContentType.DoesNotExist: ContentType matching query does not exist. /content/{content_pk}/comment/update/{comment_pk}/ View Issue

Did you find this useful? React with a 👍 or 👎

drvcodenta pushed a commit to drvcodenta/BLT that referenced this pull request Jan 21, 2025
* comments on blog added

* on comments

* pre

* change

* chages

* changes

* tests added

* pre
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add comments to the blog, use existing comments if possible - refactor to content type
2 participants