Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Peer Recognition feature #3175

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

added Peer Recognition feature #3175

wants to merge 6 commits into from

Conversation

tsu-ki
Copy link
Contributor

@tsu-ki tsu-ki commented Jan 1, 2025

Closes: #2576

Remaining changes:

  1. Failed to send kudos. Please try again. message is prompted even when the team member exists, but the kudos is sent.
Screen.Recording.2025-01-01.at.7.15.45.PM.mov

DonnieBLT
DonnieBLT requested changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please simplify this to be on the user's profile page, so it's a button with a list of people who gave kudos, there would be no text entry.

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 2, 2025

@DonnieBLT sir I've made the requested changes, please review them? thank you!

Screen.Recording.2025-01-03.at.2.23.34.AM.mov

@tsu-ki tsu-ki marked this pull request as ready for review January 2, 2025 20:56
@tsu-ki tsu-ki requested a review from DonnieBLT January 2, 2025 20:56
DonnieBLT
DonnieBLT reviewed Jan 5, 2025
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a field for a URL? So I can give kudos to any link like a PR, blog post, tweet, etc…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonnieBLT DonnieBLT DonnieBLT requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
requested changes
Projects
None yet
Milestone
No milestone
2 participants
@tsu-ki @DonnieBLT