-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenges and leaderboards #3127
Challenges and leaderboards #3127
Conversation
…o challenges-leaderboard
@DonnieBLT Sir i have made the required functionality , but the challenges are limited to 3 , just so i can confirm with you that :
|
We can start with three challenges that looks good let's let's make everything one point and then yes if you think it's better to have a separate file then that would be fine for the signals |
@DonnieBLT sir, i have made the changes and attached a video, let me know of any other changes. Thanks. |
What do you think about modifying the badge code to work with teams instead of adding new models? |
can you merge these migrations please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please merge migrations
Apologies for the delay. |
@DonnieBLT sir , Is it good to merge now? |
Can you just change the files necessary for the functionality? 93 files changed seems like too much. |
@DonnieBLT sir ,The files changed when i ran pre-commit on them , most of the files are same but adjusted by pre-commit, as the test case wasnt passing. |
I think the pre commit only does staged files? It would be faster for me to review with smaller changes |
5eb90b3
to
689f1dc
Compare
689f1dc
to
196ab0c
Compare
@DonnieBLT sir , i have reverted the changes , the pre-commit in the test is running on all the files , as it shows error in blt/middleware/iprestrict.py , whereas i havent changes the file in my commit . In CI , pre-commit runs like pre-commit run --all-files so its checking for all the files . |
comments/migrations/0007_remove_comment_issue_comment_content_type_and_more.py
Outdated
Show resolved
Hide resolved
@DonnieBLT sir ,Since you have approved , should i run pre-commit run --all-files so that it passes the test-case? |
fixes #3126
Used the points model in user.py to award points to users when they complete challenges.
Teams will earn team_points when they complete challenges.
For the navigation structure:
Under the Users section in the sidenav, Introduced a new page for challenges. Points earned from these challenges are also added showcased on the existing leaderboard.
Under the new Teams section in the sidenav:
a new page for challenges for teams.
a Team Leaderboard with views: global rankings
Separating badges for challenges in necessary because if in future we want to add weekly challenges , we wont need to assign badges for every completion of challenge.
https://github.com/user-attachments/assets/033dcdf8-2e8f-4818-9122-27f9571567ac