-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncation added for String length #3022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather increase the minimum to be 500 characters in the model thank you
sure, I'll increase it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a migration file
Can you please explain what needs to be added in the migration file? |
In Django, when you make a change to a model you need to run python manage.py makemigrations |
..yeah, that totally skipped my mind, sorry. thank you for reminding me! I’ll run the command and push the commit |
6db3f39
to
b4d1548
Compare
@DonnieBLT sir I've removed the merge migration file but it's causing the CI/CD tests to fail. Can I please get your review on this? |
the migration did not need to apply to the badge table, so I have fixed this in another commit. |
sir is it okay if I mention this PR in the leaderboard list? |
You can mention it as not being merged if you want. I have given feedback but this was not fixed. |
Fixed the string value too long error persisting in
middleware/ip_restrict.py
Closes #3018