Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncation added for String length #3022

Closed
wants to merge 14 commits into from
Closed

Conversation

tsu-ki
Copy link
Contributor

@tsu-ki tsu-ki commented Nov 30, 2024

Fixed the string value too long error persisting in middleware/ip_restrict.py
Closes #3018

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather increase the minimum to be 500 characters in the model thank you

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Dec 1, 2024

I would rather increase the minimum to be 500 characters in the model thank you

sure, I'll increase it

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a migration file

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Dec 2, 2024

This needs a migration file

Can you please explain what needs to be added in the migration file?
I initially changed the agent's field type to TextField in models and removed the max_length limit so as to increase the character limit.

@DonnieBLT
Copy link
Collaborator

In Django, when you make a change to a model you need to run python manage.py makemigrations

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Dec 2, 2024

In Django, when you make a change to a model you need to run python manage.py makemigrations

..yeah, that totally skipped my mind, sorry. thank you for reminding me! I’ll run the command and push the commit

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Dec 19, 2024

@DonnieBLT sir I've removed the merge migration file but it's causing the CI/CD tests to fail. Can I please get your review on this?

@tsu-ki tsu-ki requested a review from DonnieBLT December 28, 2024 14:27
@DonnieBLT
Copy link
Collaborator

the migration did not need to apply to the badge table, so I have fixed this in another commit.

@DonnieBLT DonnieBLT closed this Jan 1, 2025
@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 1, 2025

the migration did not need to apply to the badge table, so I have fixed this in another commit.

sir is it okay if I mention this PR in the leaderboard list?

@DonnieBLT
Copy link
Collaborator

You can mention it as not being merged if you want. I have given feedback but this was not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataError: value too long for type character varying(255)
2 participants