Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Cover func updatestatefulset #863

Merged

Conversation

k3mahesh
Copy link
Contributor

@k3mahesh k3mahesh commented Apr 4, 2024

Tests for updatestatefulset functions

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 39.03%. Comparing base (d121d86) to head (010543a).
Report is 23 commits behind head on master.

❗ Current head 010543a differs from pull request most recent head 81a4a70. Consider uploading reports for the commit 81a4a70 to get more accurate results

Files Patch % Lines
k8sutils/statefulset.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   35.20%   39.03%   +3.83%     
==========================================
  Files          19       19              
  Lines        3213     2631     -582     
==========================================
- Hits         1131     1027     -104     
+ Misses       2015     1535     -480     
- Partials       67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-cmyk shubham-cmyk changed the title tests for updatestatefulset functions test: Cover func updatestatefulset Apr 5, 2024
k3mahesh and others added 3 commits April 9, 2024 16:43
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit 454e88c into OT-CONTAINER-KIT:master Apr 13, 2024
25 checks passed
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* test case for updatestatefulset functions

Signed-off-by: Mahesh Kumar <[email protected]>

* tests: updated TestUpdateStatefulSet

Signed-off-by: Mahesh Kumar <[email protected]>

* fix: failing test

Signed-off-by: Shubham Gupta <[email protected]>

* test: Add one more case

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Mahesh Kumar <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: opstree <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants