Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add unit test #856

Merged
merged 5 commits into from
Mar 31, 2024
Merged

Conversation

shubham-cmyk
Copy link
Member

Signed-off-by: Shubham Gupta [email protected]

Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk marked this pull request as draft March 30, 2024 15:33
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 39.04%. Comparing base (d121d86) to head (279b53b).
Report is 20 commits behind head on master.

Files Patch % Lines
k8sutils/redis.go 35.71% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   35.20%   39.04%   +3.84%     
==========================================
  Files          19       19              
  Lines        3213     2648     -565     
==========================================
- Hits         1131     1034      -97     
+ Misses       2015     1546     -469     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk marked this pull request as ready for review March 31, 2024 17:00
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk merged commit 41fd164 into OT-CONTAINER-KIT:master Mar 31, 2024
22 checks passed
@shubham-cmyk shubham-cmyk deleted the improve-test branch March 31, 2024 17:50
wkd-woo pushed a commit to wkd-woo/redis-operator that referenced this pull request Apr 1, 2024
* test: Add unit test

Signed-off-by: Shubham Gupta <[email protected]>

* test: Cover TestCheckRedisCluster

Signed-off-by: Shubham Gupta <[email protected]>

* test: fix coverage

Signed-off-by: Shubham Gupta <[email protected]>

* fix: coverage

Signed-off-by: Shubham Gupta <[email protected]>

* fix: remove print statement

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: wkd-woo <[email protected]>
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* test: Add unit test

Signed-off-by: Shubham Gupta <[email protected]>

* test: Cover TestCheckRedisCluster

Signed-off-by: Shubham Gupta <[email protected]>

* test: fix coverage

Signed-off-by: Shubham Gupta <[email protected]>

* fix: coverage

Signed-off-by: Shubham Gupta <[email protected]>

* fix: remove print statement

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant