-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Validation Charts #210
Conversation
Hi @trevorb1 just did a quick first look and below are my initial comments. Currently running the pr with the Americas to see if it runs for different countries as well. I'll do a more thorough review either late this week or early next week.
|
Good call! Updated in this commit. Some sources will need to be manually re-downloaded (as I couldnt find a persistent link) - but we wont have to update the code to match
I think this comes back to the discussion in PR #203 where we create some sort of configuration file that contains data like: Canada:
iso: CAN
region: NA # North America, not 'not available'
nodes:
AR:
nice_name: atlantic_region
centre_point: xxx, yyy
gem_name: sample
gtd_name: sample
BC:
nice_name: british_columbia
centre_point: xxx, yyy
gem_name: sample
gtd_name: sample
...
I agree! Similar to above, creating some sort of configuration (that shouldnt really be changed too often) such as: technology:
bio:
fuel_in: bio
fuel_out: elec
nice_name: biomass
renewable: True
color: darkgreen
lifetime: 30
name_maps:
plexos: bio
gem: biomass
weo: bio
... fuel:
bio:
nice_name: biomass
renewable: True
color: darkgreen
name_maps:
epa: biomass
... Not saying these are the best structures or anything, but passing around these configs (which can easily be parsed with dataclasses) can replace numerous other files. Moreover, we could use similar structures for user defined capacity to simplify that process. |
I ended up adding this in this PR. There is now also a validation plot called |
Hi @trevorb1. The validation looks good to me (and functional for other countries), small suggestions (non-essential) below. Feel free to merge the PR!
Really need to get better capacity data for SPV.... Yikes! (I guess that's why we do the validation....) |
@maartenbrinkerink thanks, and both good points! Il address them in the coming days! One question I just thought of with the Do you think I should move the conversion calculation (see here) to the validation script, and leave reported |
I find |
The removal of years we dont have data for ended up being a little awkward, as some sources only report data for some countries for certain years (ie, eia has 2023 USA data, but not 2023 India). Then how they tag missing data isnt super clear to me. Its mostly updated though - with the exception of EIA capacity and IRENA generation. Im gonna merge as this is diminishing returns to continue to work on this right now! |
Description
In this PR I have added some basic validation charts to compare model results against historical years. For any year between 2015 and 2022 (inclusive), power sector generation, emission, and capacity validation charts will be generated. These charts show modelled results against reported results at a country level. Below are the sources I used:
Capacity Validation:
Generation Validation:
Emission Validation:
A couple notes:
CarbonIntensity
metric though, which is indexed (probably) overREGION
,EMISSION
,YEAR
. This can be done in a separate issue ticket, though.Issue Ticket Number
na
Documentation
na