Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: treat all warnings as errors #84

Merged
merged 2 commits into from
Jan 22, 2024
Merged

CI: treat all warnings as errors #84

merged 2 commits into from
Jan 22, 2024

Conversation

thbeu
Copy link
Contributor

@thbeu thbeu commented Jan 22, 2024

@thbeu
Copy link
Contributor Author

thbeu commented Jan 22, 2024 •
edited
Loading

https://github.com/OSGeo/shapelib/actions/runs/7612427623/job/20730024777?pr=84 reveals another issue with bBigEndian now which needs refactoring as reported in #36.

@rouault
Copy link
Member

rouault commented Jan 22, 2024

We should definitely not put warnings-as-errors in the CMakeLists.txt as default. This is too risky. This should only be set in the CI scripts

@thbeu
Copy link
Contributor Author

thbeu commented Jan 22, 2024 •
edited
Loading

We should definitely not put warnings-as-errors in the CMakeLists.txt as default. This is too risky. This should only be set in the CI scripts

Done. CMake ≥ 3.24 is required according to https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILE_WARNING_AS_ERROR.html#variable:CMAKE_COMPILE_WARNING_AS_ERROR.

@thbeu thbeu force-pushed the treat-warnings-as-errors branch from 699d01e to cc9d01f Compare January 22, 2024 17:45
@thbeu thbeu changed the title CMake: treat all warnings as errors CI: treat all warnings as errors Jan 22, 2024
@rouault
Copy link
Member

rouault commented Jan 22, 2024

Do you mind reworking the git history to fold the first 2 commits in a single one? Thanks

@thbeu thbeu force-pushed the treat-warnings-as-errors branch from f83fdc8 to 29116cb Compare January 22, 2024 18:14
@thbeu
Copy link
Contributor Author

thbeu commented Jan 22, 2024

Do you mind reworking the git history to fold the first 2 commits in a single one? Thanks

Check again :-)

@rouault
Copy link
Member

rouault commented Jan 22, 2024

Excellent. Thanks again for all your work on shapelib

@rouault rouault merged commit f88d88f into OSGeo:master Jan 22, 2024
4 checks passed
@thbeu thbeu deleted the treat-warnings-as-errors branch January 22, 2024 18:22
@thbeu
Copy link
Contributor Author

thbeu commented Jan 22, 2024 •
edited
Loading

Excellent. Thanks again for all your work on shapelib

Thanks for the lib after all! I am considering to work on #16 and #36. Let me know if this is not OK for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thbeu @rouault