Merge GDAL changes into upstream shapelib #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
resync_gdal
branch
2 times, most recently
from
3fbb9a5 to
4c7defb
Compare
- Polygon writing: avoid considering rings slightly overlapping as inner-outer rings of others (refs OSGeo/gdal#5315) OSGeo/gdal@a41e0a2 - Polygon writing: consider rings at non-constant Z as outer rings (fixes OSGeo/gdal#5315) As noted in code comments, this is an approximation of more complicated tests we'd likely have to do, that would take into account real co-planar testing, to allow detecting inner rings of outer rings in an oblique plane. OSGeo/gdal@702b19f - shpopen.c: Communicate why the file size cannot be reached when appending features (OSGeo/gdal#4140) Clearly state why the file size cannot be reached. This is important in order to correctly inform the user and prevent him/her from looking for other reasons. Related to qgis/QGIS#44202 OSGeo/gdal@91988f8 - SHPWriteObject(): prevent potential overflows on 64-bit platforms on huge geometries: OSGeo/gdal@454e5ed - SHPRestoreSHX: update SHX content length even if error occurred: OSGeo/gdal@998c91d - in creation, uses w+b file opening mode instead of wb followed by r+b, to support network file systems having sequential write only and when using CPL_VSIL_USE_TEMP_FILE_FOR_RANDOM_WRITE=YES (fixes OSGeo/gdal#7801): OSGeo/gdal@e9f9842 - fix adding features in a .dbf without columns (fixes qgis/QGIS#51247): OSGeo/gdal@17c0b0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rings of others (refs shapefile writer: issue when writing non-coplanar 3D multipolygons gdal#5315)
OSGeo/gdal@a41e0a2
(fixes shapefile writer: issue when writing non-coplanar 3D multipolygons gdal#5315)
As noted in code comments, this is an approximation of more complicated
tests we'd likely have to do, that would take into account real
co-planar testing, to allow detecting inner rings of outer rings in an
oblique plane.
OSGeo/gdal@702b19f
features (OGR/shape/shpopen.c: Communicate why the file size cannot be reached … gdal#4140)
Clearly state why the file size cannot be reached. This is important in order
to correctly inform the user and prevent him/her from looking for other reasons.
Related to QGIS crashes when trying create a Shapefile bigger than 4GB qgis/QGIS#44202
OSGeo/gdal@91988f8
platforms on huge geometries:
OSGeo/gdal@454e5ed
OSGeo/gdal@998c91d
to support network file systems having sequential write only and when
using CPL_VSIL_USE_TEMP_FILE_FOR_RANDOM_WRITE=YES (fixes Failed to write a shapefile to webhdfs gdal#7801):
OSGeo/gdal@e9f9842
OSGeo/gdal@17c0b0b
With this PR, shapelib and GDAL (OSGeo/gdal#8749) will be sync'ed again